Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in public round APIs #16925

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Expose streams in public round APIs #16925

merged 9 commits into from
Nov 1, 2024
+46 −1

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 26, 2024 •
edited
Loading

Description

Contributes to #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Sep 26, 2024
@Matt711 Matt711 added this to the Enable streams milestone Sep 26, 2024
@Matt711 Matt711 self-assigned this Sep 26, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 26, 2024
@github-actions github-actions bot added the CMake CMake build issue label Oct 31, 2024
@Matt711 Matt711 marked this pull request as ready for review October 31, 2024 01:20
@Matt711 Matt711 requested a review from a team as a code owner October 31, 2024 01:20
@Matt711 Matt711 requested review from vyasr and mythrocks October 31, 2024 01:20
@Matt711 Matt711 changed the title [WIP] Expose streams in public round APIs Expose streams in public round APIs Oct 31, 2024
ttnghia
ttnghia reviewed Oct 31, 2024
View reviewed changes
cpp/include/cudf/round.hpp Outdated Show resolved Hide resolved
Matt711
Matt711 commented Oct 31, 2024
View reviewed changes
cpp/include/cudf/round.hpp Outdated Show resolved Hide resolved
@Matt711
Copy link
Contributor Author

Matt711 commented Nov 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0a87284 into rapidsai:branch-24.12 Nov 1, 2024
102 checks passed
@Matt711 Matt711 mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@Matt711 Matt711

Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
Enable streams
Development

Successfully merging this pull request may close these issues.
3 participants
@Matt711 @bdice @ttnghia